Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-2415] migrate AboutComponent to CL #6301

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[PM-2415] migrate AboutComponent to CL #6301

merged 2 commits into from
Sep 18, 2023

Conversation

willmartian
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Migrates the browser's AboutComponent to use a CL simple dialog and be a standalone component.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Screenshot 2023-09-14 at 6 12 05 PM

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@willmartian willmartian requested a review from a team as a code owner September 14, 2023 22:17
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Sep 14, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 14, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 542c8013-eadd-4b4e-b9f8-19bc9fbe4954

No New Or Fixed Issues Found

@willmartian willmartian changed the title [PM-2412] migrate AboutComponent to CL [PM-2415] migrate AboutComponent to CL Sep 15, 2023
@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label Sep 18, 2023
@willmartian willmartian merged commit b6ea1b1 into master Sep 18, 2023
21 of 23 checks passed
@willmartian willmartian deleted the ps/PM-2412/migrate-about-dialog branch September 18, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willmartian @bitwarden-bot @Hinton