Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-3277] 1password1pux importer can also import json #6049

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[PM-3277] 1password1pux importer can also import json #6049

merged 1 commit into from
Sep 19, 2023

Conversation

djsmith85
Copy link
Contributor

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The .1pux-format is technically just a zip-file that contains a file named export.datawhich is a json file. These changes add support to upload either a 1pux or the export.data file directly. The thought to change this came through the recent addtion of the ProtonPass importer.

Code changes

  • apps/cli/src/tools/import.command.ts: Ensure that files ending with .1pux are treated as zip files and extract the export.data.
  • apps/web/src/app/tools/import-export/import.component.ts: Ensure that files ending with .1pux are treated as zip files and extract the export.data.
  • libs/importer/src/models/import-options.ts: Display that the 1password 1pux importer support 1pux but also the upload of the unzipped export.data (json)

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@djsmith85
1password1pux importer can import json
2f9f97d 
The .1pux-format is technically just a ziup-file that contain a file named `export.data`which is a json file.
These changes add support to upload either a 1pux or the export.data file directly.
The thought to change this came through the recent addtion of the ProtonPass importer.
@djsmith85 djsmith85 requested a review from a team as a code owner August 16, 2023 16:39
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Aug 16, 2023
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – f02c71e3-4893-45e3-8f54-68b4118d28b1

No New Or Fixed Issues Found

aj-rosado
aj-rosado approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@aj-rosado aj-rosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Sep 19, 2023
@djsmith85 djsmith85 enabled auto-merge (squash) September 19, 2023 09:04
@djsmith85 djsmith85 merged commit 98cfe1b into master Sep 19, 2023
75 of 76 checks passed
@djsmith85 djsmith85 deleted the tools/pm-3277/1password1pux-supports-1pux-and-json branch September 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-rosado aj-rosado aj-rosado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djsmith85 @bitwarden-bot @aj-rosado