-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1119] [PM-1923] [AC-701] Import into a specified folder or collection #5683
Conversation
Extended import.service and abstraction to receive importTarget on import() Pass selectedImportTarget to importService.import() Wrote unit tests
…nt library to the import
Map ciphers with no folder/no collection to the new rootFolder when selected by the user Modified and added unit tests
…thub.com/bitwarden/clients into AC-1119-flexible-collections-import-page
…thub.com/bitwarden/clients into AC-1119-flexible-collections-import-page
…-1119-flexible-collections-import-page
…-1119-flexible-collections-import-page
Rename old submit() to performImport() Create submit arrow function calling performImport() (which can be overridden/called by org-import.component) Remove #form and ngNativeValidate Add bitSubmit and bitFormButton directives Remove now unneeded loading variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I only have a few more comments/suggestions and then I think we'll be all set!
apps/web/src/app/admin-console/organizations/tools/import-export/org-import.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Nice job!
…-1119-flexible-collections-import-page
…-1119-flexible-collections-import-page
…-1119-flexible-collections-import-page
Hide the `My Vault` entry when policy is active Always check if the policy applies and disable the formGroup if no vault-target is selectable
641a05d
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good to me!
* Display select folder/collection in targetSelector Filter the no-folder entry from the folderViews-observable Add labels for the targetSelector placeholders * Update importTargetHint and remove importTargetOrgHint * Update language on importUnassignedItemsError * Add help icon with link to the import documentation
Re-requesting review from @aj-rosado due to merging PR #5933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that @shane-melton and @eliykat previously approved it, I went through the recent commits and none had Admin Console related changes, approving on behalf of them.
Type of change
Objective
Flexible collections AC-1119
Tools ->Import data
andOrganization -> Select Org -> Settings -> Import data
)Tech debt PM-1923 [AC-701]
Code changes
UI rework:
import.service
Enabling import into a specific folder or collections
import.service
Screenshots
BEFORE:
AFTER:
Vault selector:
Individual vault:
Organizational vault:
Before you submit