Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded sidebarAction in main.background #4544

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

djsmith85
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove unneeded sidebarAction in main.background

With #3571 the updating of the badge got refactored. Moving this variable/action into browserApi.getSidebarAction

Code changes

  • apps/browser/src/background/main.background.ts: Removed declaration and defintion of sidebarAction

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

With #3571 the updating of the badge got refactored. Moving this variable/action into `browserApi.getSidebarAction`
@djsmith85 djsmith85 requested a review from a team January 23, 2023 20:25
@djsmith85 djsmith85 merged commit 6883963 into master Jan 31, 2023
@djsmith85 djsmith85 deleted the remove-unneeded-sidebaraction branch January 31, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants