Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS-2320] Import API service refactor #4529

Merged
merged 9 commits into from
Jan 30, 2023

Conversation

djsmith85
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Extract methods used for imports from ApiService into ImportApiService
Move files related to import.service into separate folders (services/abstractions)

Code changes

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Removed methods from ApiService impl and abstraction
Create import-api.service impl and abstraction
Moved import.service into abstractions/import/import.service.abstraction
Moved import.service into services/import/import.service
Change imports to use new services
@djsmith85 djsmith85 requested a review from a team January 20, 2023 20:11
MGibson1
MGibson1 previously approved these changes Jan 25, 2023
Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, glad this was an easy one

@djsmith85 djsmith85 added the needs-qa Marks a PR as requiring QA approval label Jan 25, 2023
MGibson1
MGibson1 previously approved these changes Jan 26, 2023
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Jan 30, 2023
@djsmith85 djsmith85 merged commit b7d38f0 into master Jan 30, 2023
@djsmith85 djsmith85 deleted the PS-2320-import-api-service-refactor branch January 30, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants