Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-deny GitHub CI action #35

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

repi
Copy link
Contributor

@repi repi commented Dec 15, 2019

To verify all dependencies are using permissible licenses and that there are no duplicate versions of dependencies.

For a small crate like this it is likely not super useful, but hoping it could help a bit and is easy to set up and use.

For more info:
https://github.com/EmbarkStudios/cargo-deny
https://github.com/EmbarkStudios/cargo-deny-action

To verify all dependencies are using pemissable licenses and that there are no duplicate vesions of dependencies.

For a small crate like this it is likely not super userful, but hoping it could help a bit and is easy to set up and use
@repi
Copy link
Contributor Author

repi commented Dec 15, 2019

Ah that didn't go that well, GitHub Actions not enabled/supported in this repo?

Thought about moving over from Travis to GitHub Actions? We've done it for all of our repos and have been working really well and quite a bit faster.

If it is enabled in this repo one should be able to continue use travis for the main build and GitHub Action for this check though

@bitshifter
Copy link
Owner

Local and third party Actions appear to be enabled for this repository. I haven't used Actions at all. What went wrong?

@repi
Copy link
Contributor Author

repi commented Dec 15, 2019

Not fully sure, usually it picks up the GitHub Action directly when adding the file for it and starts build it as an additional check in the repo. AFAIK there is no other configuration for enabling a GitHub Action, should be enough to have the .github/workflows/xxx files

@repi
Copy link
Contributor Author

repi commented Dec 15, 2019

But in this PR it didn't trigger that new workflow / check

@bitshifter
Copy link
Owner

Maybe it needs to be merged before it will work? I don't see any harm in merging it in any case.

@repi
Copy link
Contributor Author

repi commented Dec 15, 2019

Yeah could be that it needs to be on master first if the PR creator is not the repo owner.

Can be merged, then one can at a minimum run it locally with cargo deny check in the root. But hopefully the CI action gets going also

@bitshifter bitshifter merged commit 7fc18a9 into bitshifter:master Dec 15, 2019
@repi repi deleted the cargo-deny branch December 16, 2019 00:01
@repi
Copy link
Contributor Author

repi commented Dec 16, 2019

That worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants