Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max decimal place + trailing zeroes when in BTC #640

Merged
merged 1 commit into from
Jul 8, 2015

Conversation

dabura667
Copy link
Contributor

Before this patch:

0.000490000098759847 BTC per kB

After this patch:

0.00049 BTC per kB

Before:

0.00043872987579283 BTC per kB

After:

0.00043873 BTC per kB

@cmgustavo
Copy link
Member

LGTM. Thanks!

cmgustavo added a commit that referenced this pull request Jul 8, 2015
Fix max decimal place + trailing zeroes when in BTC
@cmgustavo cmgustavo merged commit ea0adc1 into bitpay:master Jul 8, 2015
@cmgustavo
Copy link
Member

In some cases, I am getting this Angular error: Lexer Error: Unexpected at column{1} in expression [{2}]..
I will have to reverse this PR.

@dabura667
Copy link
Contributor Author

Maybe remove the regex and just leave .toFixed(8) and see if that works.

@dabura667
Copy link
Contributor Author

trailing zeroes shouldn't be that bad. Most people are probably using bits or mBTC anyways.

@cmgustavo
Copy link
Member

Just .toFixed(8) doesn't work.

@cmgustavo
Copy link
Member

I think these javascript functions don't work inside the angular template. We should do a filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants