Update BIP91 confirmation window and enforcement. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshilliard
force-pushed
the
bip91-thresholdupdate
branch
from
263d922
to
bab79c2
Compare
Christewart
reviewed
Jun 15, 2017
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGSIGNAL].bit = 4; | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGSIGNAL].nStartTime = 1496275200; // June 1st, 2017. | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGSIGNAL].nTimeout = 1510704000; // November 15th, 2017. | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGSIGNAL].nOverrideMinerConfirmationWindow = 672; // ~4.67 days |
There was a problem hiding this comment.
Your comment says 'immediate enforcement', is that right? Doesn't this indicate there is a 4.67 wait between LOCKED_IN and ACTIVE? (Looking at this graphic https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki#state-transitions)
There was a problem hiding this comment.
It enforces on lock in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make BIP91 activation faster and less likely to conflict with BIP148.