Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP 8: Elaborate and clarify parameter selection #1070

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Feb 17, 2021

No description provided.

Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 72bf969

Clearly better wording than before. In particular for startheight "a majority of economic activity is expected to have upgraded" is provides way better guidance than "reasonable number of full nodes".

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 72bf969

@darosior
Copy link
Member

darosior commented Feb 26, 2021

Note that you also have "recommended a year" in the Motivation section regarding the flag day choice that in the spirit of these changes should imo be removed.
EDIT: ie darosior@ca77342

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
@luke-jr luke-jr merged commit 5c6f023 into bitcoin:master Feb 26, 2021
@ajtowns
Copy link
Contributor

ajtowns commented Feb 27, 2021

Post-merge ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants