Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin for Developers: Change links #770

Merged
merged 1 commit into from
Feb 25, 2015
Merged

Bitcoin for Developers: Change links #770

merged 1 commit into from
Feb 25, 2015

Conversation

louisjc
Copy link
Contributor

@louisjc louisjc commented Feb 24, 2015

I find misleading that the Bitcoin for Developers page has the same "Get started with Bitcoin" button as the other pages but with a different link (english only, even if the button is translated).
I propose:

  1. Restore the same link for the button as the other pages (Getting started).
  2. Add a Developer Documentation link without translating: I think this is not a problem / more indicative because the documentation is English only.

@harding
Copy link
Contributor

harding commented Feb 24, 2015

@louisjc good idea! Thanks! For everyone else, here's what it looks like:

2015-02-24-075622_630x241_scrot

I think having a lonely untranslated string might be a bit confusing, so I think the docs link should say, "Developer Documentation (English)". Of course, that looks weird when you're on the English translation, so we should probably put in a conditional like this:

{% case page.lang %}
  {% when 'en' %}
    (link text "Developer Documentation")
  {% else %}
    (link text "Developer Documentation (English)")
{% endcase %}

What do you think?

@louisjc
Copy link
Contributor Author

louisjc commented Feb 24, 2015

Good idea, is there a reason not to do directly:

<a href="...">Developer Documentation {% if page.lang != "en" %}(English){% endif %}</a>

@harding
Copy link
Contributor

harding commented Feb 24, 2015

@louisjc indeed, that direct way is better!

@louisjc
Copy link
Contributor Author

louisjc commented Feb 24, 2015

@harding I've rebase added it!

@harding
Copy link
Contributor

harding commented Feb 24, 2015

Tested both English and other languages, and it LGTM (screenshot from German below). If nobody else has any comments, I'll merge this tomorrow. Thanks!

2015-02-24-092056_548x242_scrot

@harding harding merged commit de3138d into bitcoin-dot-org:master Feb 25, 2015
harding added a commit that referenced this pull request Feb 25, 2015
* #765: Links: Replace Dead BitLegal.io With Wikipedia
* #770: Bitcoin for Developers: Change links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants