Add xwinograd #798
Open
Add xwinograd #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! As long as the duplicated template IDs don't actually cause any bugs at runtime, beside the CI complaining on this PR. Maybe @VictorSanh would know if duplicated template IDs will be a problem. |
|
hmm locally i can't pass the test/test_templates.py test, but on the online CI, it does not complain... looking into that. |
|
could you bring the latest changes from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just duplicated the files including the ID for fr & pt as I didn't run into any problems after that.
If it's not ok I can also change their IDs, but leave the duplicate prompts.
@haileyschoelkopf @thomasw21 @lintangsutawika