Various improvements to the contributors example
#12217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [X] Make contributor colors persistent between runs - [X] Move text to top left and add padding - [X] Remove `Contributor:` text. It's obvious what is being shown from context, and we can simplify `SelectionState`. - [X] Show the number of commits authored - [X] Use `Hsla` for the color constants - [ ] ? Clean up collision code with bounding volumes
alice-i-cecile
added
C-Examples
|
|
||
| Ok(contributors) | ||
| } | ||
|
|
||
| /// Give each unique contributor name a particular hue that is stable between runs. | ||
| fn name_to_hue(s: &str) -> f32 { |
There was a problem hiding this comment.
Can we combine this with #12173 to get a nicely dispersed collection of hues?
There was a problem hiding this comment.
I played with this for funsies, but I feel like the distribution of hues from the hash alone is probably good enough.
alice-i-cecile
approved these changes
Mar 1, 2024
|
I like the commit count: that's really neat! |
afonsolage
approved these changes
Mar 1, 2024
bushrat011899
approved these changes
Mar 1, 2024
| const SATURATION_SELECTED: f32 = 0.9; | ||
| const LIGHTNESS_SELECTED: f32 = 0.7; | ||
| const ALPHA: f32 = 0.92; | ||
| const SELECTED: Hsla = Hsla::hsl(0.0, 0.9, 0.7); |
There was a problem hiding this comment.
Much nicer! Only suggestion is Oklch might look nicer since it has better uniformity
There was a problem hiding this comment.
I'm honestly not sure how to use Oklch. Maybe I read up a bit more. I naively converted these values to Oklch and kept the rest of the code the same and some of them look okay but most look dark and saturated.
| let delta = time.delta_seconds(); | ||
|
|
||
| for mut velocity in &mut velocity_query { | ||
| velocity.translation.y -= GRAVITY * delta; | ||
| } | ||
| } | ||
|
|
||
| /// Checks for collisions of contributor-birds. | ||
| /// Checks for collisions of contributor-birbs. |
rparrett
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective / Solution - Use `Hsla` for the color constants (Fixes bevyengine#12203) And a few other improvements: - Make contributor colors persistent between runs - Move text to top left where the birbs can't reach and add padding - Remove `Contributor:` text. It's obvious what is being shown from context, and then we can remove `has_triggered`. - Show the number of commits authored - Some system names were postfixed with `_system` and some weren't. Removed `_system` for consistency. - Clean up collision code slightly with a bounding volume - Someone accidentally typed "bird" instead of "birb" in one comment. - Other misc. cleanup ## Before <img width="1280" alt="image" src="https://github.com/bevyengine/bevy/assets/200550/9c6229d6-313a-464d-8a97-0220aa16901f"> ## After <img width="1280" alt="image" src="https://github.com/bevyengine/bevy/assets/200550/0c00e95b-2f50-4f50-b177-def4ca405313">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective / Solution
Hslafor the color constants (Fixes Clean up color logic in contributors.rs example #12203)And a few other improvements:
Contributor:text. It's obvious what is being shown from context, and then we can removehas_triggered._systemand some weren't. Removed_systemfor consistency.Before
After