Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only invalidate configure repos with fetch --configure --force #23644

Closed
wants to merge 1 commit into from
Closed

Only invalidate configure repos with fetch --configure --force #23644

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 17, 2024

Also cleans up an unused field on BazelFetchAllValue.

@fmeum
Only invalidate configure repos with fetch --configure --force
c44a8b8 
Also cleans up an unused field on `BazelFetchAllValue`.
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Sep 17, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 17, 2024

@meteorcloudy I thought about #23639 more and actually like the fact that --configure and --force are now independent, so this only fixes another issue I found.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 18, 2024
@meteorcloudy
Copy link
Member

meteorcloudy commented Sep 18, 2024 •
edited
Loading

Ah, okay, I haven't put much thoughts into this (or I forgot😅), can you explain a bit your reasons in #23639 and maybe we could close it then?

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 19, 2024
@fmeum fmeum deleted the 23639-consistent-bazel-fetch branch September 19, 2024 09:59
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 19, 2024

@bazel-io fork 7.4.0

@bazel-io bazel-io mentioned this pull request Sep 19, 2024
Closed
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 19, 2024
@fmeum @bazel-io
Only invalidate configure repos with fetch --configure --force
5d10935 
Also cleans up an unused field on `BazelFetchAllValue`.

Closes bazelbuild#23644.

PiperOrigin-RevId: 676333873
Change-Id: Ida7149a1c5642facaeed7fb68bf9f451016c359c
@bazel-io bazel-io mentioned this pull request Sep 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2024
@bazel-io @fmeum @meteorcloudy
[7.4.0] Only invalidate configure repos with `fetch --configure --f…
577a3aa 
…orce` (#23678)

Also cleans up an unused field on `BazelFetchAllValue`.

Closes #23644.

PiperOrigin-RevId: 676333873
Change-Id: Ida7149a1c5642facaeed7fb68bf9f451016c359c

Commit
5534679

---------

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: Yun Peng <pcloudy@google.com>
iancha1992 pushed a commit that referenced this pull request Sep 20, 2024
@fmeum @iancha1992
Only invalidate configure repos with fetch --configure --force
f458a84 
Also cleans up an unused field on `BazelFetchAllValue`.

Closes #23644.

PiperOrigin-RevId: 676333873
Change-Id: Ida7149a1c5642facaeed7fb68bf9f451016c359c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @meteorcloudy