Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging workflow on AL2023 #741

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

jamesbornholt
Copy link
Member

Description of change

This is prep for moving the CI to AL2023. That OS sets a very high ulimit for open files, and that seems to interact badly with yum on Centos 7. The net result is that our packaging workflow takes hours to install OS dependencies. There's an issue: docker/buildx#379. A workaround suggested there is to just lower the ulimit, which works in my testing.

Does this change impact existing behavior?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

It sets a much higher ulimit for open files, and that seems to interact
badly with `yum` on Centos 7. The net result is that our packaging
workflow takes hours

Signed-off-by: James Bornholt <bornholt@amazon.com>
@jamesbornholt jamesbornholt marked this pull request as ready for review February 8, 2024 03:34
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this and great timing: I started a run just yesterday and noticed it seemed slow, but only this morning I found out it had taken hours!

@sauraank sauraank added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@jamesbornholt jamesbornholt added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@monthonk monthonk added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@sauraank sauraank added this pull request to the merge queue Feb 9, 2024
Merged via the queue into awslabs:main with commit cfc11cd Feb 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants