-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packaging workflow on AL2023 #741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sets a much higher ulimit for open files, and that seems to interact badly with `yum` on Centos 7. The net result is that our packaging workflow takes hours Signed-off-by: James Bornholt <bornholt@amazon.com>
jamesbornholt
temporarily deployed
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Inactive
jamesbornholt
had a problem deploying
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Failure
jamesbornholt
temporarily deployed
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 7, 2024 23:08
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
February 8, 2024 02:19
— with
GitHub Actions
Inactive
passaro
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing this and great timing: I started a run just yesterday and noticed it seemed slow, but only this morning I found out it had taken hours!
arsh
approved these changes
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is prep for moving the CI to AL2023. That OS sets a very high ulimit for open files, and that seems to interact badly with
yum
on Centos 7. The net result is that our packaging workflow takes hours to install OS dependencies. There's an issue: docker/buildx#379. A workaround suggested there is to just lower the ulimit, which works in my testing.Does this change impact existing behavior?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).