Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose approximateArrivalTimestamp from JsonFriendlyRecord #86

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

zdjohn
Copy link
Contributor

@zdjohn zdjohn commented Jul 1, 2016

regarding on issue #85

Even though ApproximateArrivalTimestamp is becoming available in Record. However it is not exposed in JsonFriendlyRecord.
This means "ApproximateArrivalTimestamp" is not exposed to anyone who uses KCL and use ProcessRecordsMessage to consume Kinesis Stream. (e.g. .Net developers like me)

tested locally and working as expected

@pfifer
Copy link
Contributor

pfifer commented Jul 11, 2016

Please confirm that we can use, modify, copy, and redistribute this contribution. After that I can begin merging the changes.

Thanks.

@zdjohn
Copy link
Contributor Author

zdjohn commented Jul 11, 2016

I confirm that this pull request may be modified, copied and redistributed under the terms of the Amazon Software License.

@pfifer pfifer self-assigned this Jul 12, 2016
@pfifer pfifer added this to the v1.6.5 milestone Jul 21, 2016
@pfifer pfifer merged commit 2104f35 into awslabs:master Jul 21, 2016
@sid88in
Copy link

sid88in commented May 31, 2017

@zdjohn I am trying to insert approximateArrivalTimestamp in the S3 from the record in firehose.

POST API -> FIREHOSE -> S3

Is it possible to get approximateArrivalTimestamp in S3 without using lambda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants