-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CAPI Backup and add filter for cluster name #6313
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6313 +/- ##
=======================================
Coverage 75.13% 75.13%
=======================================
Files 447 447
Lines 37266 37267 +1
=======================================
+ Hits 28001 28002 +1
Misses 7700 7700
Partials 1565 1565
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vignesh-goutham The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.17 |
@vignesh-goutham: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@vignesh-goutham: #6313 failed to apply on top of branch "release-0.17":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Spoke with @raymond-zhang00 and will be storing two backups with the first one including all the resources and not just the cluster name so that we can cover the scenario for restoration where mgmt cluster fails to upgrade and customer loses access to both kind cluster and mgmt cluster. This helps make it easier to recover the workload cluster resources into a new cluster if the original mgmt cluster is not recoverable. |
/cherrypick release-0.16 |
@vignesh-goutham: #6313 failed to apply on top of branch "release-0.16":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…r flags for backups (#6360) * add backup cluster retries on infrastructure error (#6211) * adding bootstrap backup for upgrade failure (#6086) * Fix CAPI Backup and add filter for cluster name (#6313) * best effort backup and bootstrap backup to different directory (#6332) * Update clusterctl move regex --------- Co-authored-by: Raymond Zhang <67798267+raymond-zhang00@users.noreply.github.com>
Description of changes:
Set the context to right management cluster when upgrading both mgmt and workload cluster for taking backup.
Set cluster name filter for backing up the cluster that is getting upgraded.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.