Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tinkerbell tests that cannot be run in CI #5926

Merged
merged 1 commit into from
May 25, 2023

Conversation

ahreehong
Copy link
Member

@ahreehong ahreehong commented May 25, 2023

Issue #, if available:

Description of changes:
Skips TestTinkerbellUpgrade127MulticlusterWorkloadClusterWorkerScaleup and TestTinkerbellUpgrade127MulticlusterWorkloadClusterWorkerScaleDown due to hardware limitations

Skips TestTinkerbellKubernetes127RedHatSimpleFlow as it cannot be run in our CI right now

Re-enables a couple packages tests as well

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 25, 2023
@eks-distro-bot eks-distro-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #5926 (ca5df8c) into main (7fac0f3) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5926      +/-   ##
==========================================
- Coverage   73.75%   73.63%   -0.12%     
==========================================
  Files         452      452              
  Lines       37864    37984     +120     
==========================================
+ Hits        27926    27969      +43     
- Misses       8315     8393      +78     
+ Partials     1623     1622       -1     

see 15 files with indirect coverage changes

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/approve
/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahreehong
Copy link
Member Author

/retest

@eks-distro-bot eks-distro-bot merged commit 667124e into aws:main May 25, 2023
ddjjia pushed a commit to ddjjia/eks-anywhere that referenced this pull request May 26, 2023
ddjjia pushed a commit to ddjjia/eks-anywhere that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants