Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect e2e for external etcd #5799

Merged
merged 1 commit into from
May 9, 2023

Conversation

mitalipaygude
Copy link
Member

Issue #, if available:

Description of changes:
Tinkerbell does not support external etcd, removing e2e for 1.27 for external etcd.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #5799 (5990605) into main (6e9027c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5799   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files         450      450           
  Lines       37562    37562           
=======================================
  Hits        27609    27609           
  Misses       8321     8321           
  Partials     1632     1632           

@ahreehong
Copy link
Member

/lgtm

@ahreehong
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahreehong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit e470d4c into aws:main May 9, 2023
ddjjia pushed a commit to ddjjia/eks-anywhere that referenced this pull request Jun 8, 2023
@mitalipaygude mitalipaygude deleted the rem_test branch June 18, 2024 17:34
@sp1999 sp1999 mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants