Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'Result' enum and replace with 'MetricResult' due to conflict with Kotlin stdlib #808

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rli
Copy link
Contributor

@rli rli commented Aug 8, 2024

Problem

The Result name presents an ergonomic issue due to the inherent conflict with the kotlin.Result type

Solution

Replace with MetricResult and automatically prepend Metric on any enum output that conflicts with the kotlin package namespace

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Update Gradle to 8.5
* Change dependency declarations to version catalog
* Update Kotlin to 1.9.21
* Update everit-json-schema to 1.14.1
* Update kotlinpoet to 1.15.3
* Update jackson to 1.16.0
Base automatically changed from rli/jb-telemetry-update to main August 8, 2024 00:47
@rli rli marked this pull request as ready for review August 19, 2024 22:21
@rli rli requested a review from a team as a code owner August 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant