chore: Upgrade to OpenSSL 3 for SAM CLI Installer #7328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
lucashuy
reviewed
Aug 7, 2024
installer/pyinstaller/build-linux.sh
Outdated
| @@ -16,7 +16,7 @@ if [ "$python_version" = "" ]; then | |||
| fi | |||
|
|
|||
| if [ "$openssl_version" = "" ]; then | |||
| openssl_version="1.1.1w"; | |||
| openssl_version="3.3.1"; | |||
There was a problem hiding this comment.
Can we use 3.0.x instead? This one is the LTS release and is supported for a bit longer than 3.3.x.
There was a problem hiding this comment.
Oh sure, will switch to 3.0.14. Thanks!
dkphm
force-pushed
the
openssl3
branch
3 times, most recently
from
eae3db0
to
807bb95
Compare
dkphm
changed the title
hawflau
approved these changes
Aug 14, 2024
lucashuy
approved these changes
Aug 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
OpenSSL 1.0 is EOL and we need to upgrade to use OpenSSL 3.
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.