Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): support of m7i and m7i-flex ec2-instancetypes #27156

Merged

Conversation

xXPOLYGONXx
Copy link
Contributor

@xXPOLYGONXx xXPOLYGONXx commented Sep 15, 2023

Support of M7i and M7i-flex EC2-Instancetypes.
They were introduced here and are also integrated in AWS-Cloudformation


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 15, 2023 07:20
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@xXPOLYGONXx xXPOLYGONXx changed the title feat(ec2): add m7i and m7i-flex instances feat(ec2): Support of M7i and M7i-flex EC2-Instancetypes Sep 15, 2023
@xXPOLYGONXx
Copy link
Contributor Author

Exemption Request

This PR is similar to this, which didnt need changes to readme and tests.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 15, 2023
@scanlonp scanlonp added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Sep 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 15, 2023 15:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rearrange the order of the enum to be consistent with its current order. Put the instance types that are written in words right above their corresponding abbreviation.

Otherwise looks good. Thanks for this addition!

@mergify mergify bot dismissed scanlonp’s stale review September 15, 2023 15:38

Pull request has been modified.

@xXPOLYGONXx
Copy link
Contributor Author

Thanks for the exemption.
I applied your suggestion to the newest commit.

scanlonp
scanlonp previously approved these changes Sep 15, 2023
@xXPOLYGONXx xXPOLYGONXx changed the title feat(ec2): Support of M7i and M7i-flex EC2-Instancetypes feat(ec2): support of m7i and m7i-flex ec2-instancetypes Sep 15, 2023
@xXPOLYGONXx xXPOLYGONXx marked this pull request as draft September 15, 2023 15:49
@mergify mergify bot dismissed scanlonp’s stale review September 15, 2023 15:52

Pull request has been modified.

@xXPOLYGONXx xXPOLYGONXx marked this pull request as ready for review September 15, 2023 16:34
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f51dc45
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fe0955f into aws:main Sep 15, 2023
13 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants