Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildpack permission issue for Heroku #5

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Fix buildpack permission issue for Heroku #5

merged 2 commits into from
Oct 10, 2019

Conversation

Macleykun
Copy link
Contributor

Now if users would deploy from AvaIre, they wouldn't have this issue (b/c the last run buildpack doesn't have this change). However users who do use the official latest one for the website repo, do notice this problem.

I didn't include any remove stuff here, b/c i'm not sure which files/folder can be deleted to safe space (and improve boot time slightly). Because this repo is still in beta.

However if you do wanna point out what can be removed, this is the current list of stuff that i'm not sure can be removed:

-rw------- .editorconfig
drwx------ .git
-rw------- .gitattributes
drwx------ .github
-rw------- .gitignore
drwx------ .profile.d
-rw------- LICENSE.md
-rw------- Procfile
-rw------- README.md
drwx------ app
-rw------- artisan
drwx------ backgrounds
drwx------ bootstrap
-rw------- buildpack-run.sh
-rw------- composer.json
-rw------- composer.lock
drwx------ config
drwx------ database
drwx------ node_modules
-rw------- package.json
-rw------- phpunit.xml
drwx------ resources
drwx------ routes
-rw------- server.php
drwx------ storage
drwx------ tests
drwx------ vendor
-rw------- webpack.mix.js
-rw------- yarn.lock

For the record, i'm talking about removing files that aren't needed to RUN.

Macleykun and others added 2 commits October 10, 2019 09:17
Jk there isn't much improved logic :^)
@Senither Senither changed the title Fix permission issue Fix buildpack permission issue for Heroku Oct 10, 2019
@Senither Senither merged commit 328f66e into avaire:master Oct 10, 2019
@Macleykun Macleykun deleted the patch-1 branch October 10, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants