ACP-77: Update ConvertSubnetTx
#3397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Sep 18, 2024
Comment on lines
+96
to
+97
| // Initial balance for this validator | ||
| Balance uint64 `serialize:"true" json:"balance"` |
There was a problem hiding this comment.
This PR does allow the validator to be initially inactive (by having a 0 balance)
StephenButtolph
commented
Sep 18, 2024
Comment on lines
+98
to
+102
| // [Signer] is the BLS key for this validator. | ||
| // Note: We do not enforce that the BLS key is unique across all validators. | ||
| // This means that validators can share a key if they so choose. | ||
| // However, a NodeID + Subnet does uniquely map to a BLS key | ||
| Signer signer.Signer `serialize:"true" json:"signer"` |
There was a problem hiding this comment.
Rather than using signer.Signer - should we just us the bls.ProofOfPossession struct? If we were to ever change the format of the BLS key... having the interface may be nice... But it feels a bit weird to use an interface where only one value is valid.
StephenButtolph
changed the base branch from
implement-acp-77-tx-base
to
implement-acp-77-sov-validators-state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested