Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P-chain ACP-103 complexity calculations #3209

Merged
merged 285 commits into from
Aug 5, 2024
Merged

Implement P-chain ACP-103 complexity calculations #3209

merged 285 commits into from
Aug 5, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

This PR introduces the methods required to calculate complexity of P-chain transactions.

Refactored logic out of #3188.

  • The bandwidth complexity is fully implemented.
  • The DBRead and DBWrite complexities are implemented, but may require additional configuration.
  • The Compute complexity is not implemented in this PR.

How this works

  • Bandwidth complexity is just the number of bytes per transaction/input/output.
  • DBReads is the number of reads that will be performed against disk for the operations.
  • DBWrites is the number of writes (and deletes) that will be performed against disk for the operations.
  • Compute is not implemented, as it requires additional benchmarking.

How this was tested

  • Valid transactions are included for every transaction type to ensure that any future breaking changes are caught by CI.
  • The bandwidth complexity is tested against the actual serialized format.

@abi87
Merge branch 'master' into e-fork-scaffolding
2b05cf1
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
0baba01
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
9c4a2b3 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
9b97764
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
1368b48
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
56343d3 
…ees-calculators
@abi87
fork switch to the avm
a4b81e6
@abi87
Merge branch 'master' into e-fork-scaffolding
392e935
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
78a1a5c
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
59348c7 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
d3a733e
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
a362312
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
3bcb51a 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
f735491
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
6a1af7c
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
e375a83 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
33e3b70
@abi87
latestFork in avm
507636e
@abi87
default test config for a few unit tests
399dfc8
@abi87
come more unit tests helpers
089af5e
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
bf58efb
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
cf039ed 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
3c52428
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
198c910
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
4c674f0 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
e34e3de
@abi87
Merge branch 'master' into e-fork-scaffolding
7feb04f
@abi87
Merge branch 'e-fork-scaffolding' into codec_upgrades_dynamic_fees
43169f4
@abi87
Merge branch 'codec_upgrades_dynamic_fees' into p-chain_introducing-f…
9265060 
…ees-calculators
@abi87
Merge branch 'master' into e-fork-scaffolding
7d7d1f7
@StephenButtolph StephenButtolph changed the base branch from master to simplify-static-fee-calculations July 28, 2024 00:20
Base automatically changed from simplify-static-fee-calculations to master July 30, 2024 16:29
marun
marun reviewed Jul 30, 2024
View reviewed changes
vms/platformvm/txs/fee/calculator_test.go Outdated Show resolved Hide resolved
vms/platformvm/txs/fee/calculator_test.go Outdated Show resolved Hide resolved
vms/platformvm/txs/fee/complexity.go Outdated Show resolved Hide resolved
vms/platformvm/txs/fee/complexity.go Show resolved Hide resolved
vms/platformvm/txs/fee/complexity_test.go Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit f145d6b Aug 5, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the implement-acp-103-tx-metering branch August 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun marun approved these changes

@abi87 abi87 abi87 approved these changes

@danlaine danlaine Awaiting requested review from danlaine

@dhrubabasu dhrubabasu Awaiting requested review from dhrubabasu

Assignees

@StephenButtolph StephenButtolph

Labels
acp103
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.11
Development

Successfully merging this pull request may close these issues.
5 participants
@StephenButtolph @marun @abi87 @meaghanfitzgerald @joshua-kim