[e2e] Simplify pre-funded key usage #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-simplify-key-usage
branch
2 times, most recently
from
d0d2262
to
de1e0c0
Compare
marun
force-pushed
the
e2e-simplify-key-usage
branch
from
aa27154
to
0ba5d07
Compare
|
Updated to fix an unrelated latent bug that cause the e2e job to fail. |
marun
force-pushed
the
e2e-simplify-key-usage
branch
from
e872971
to
289678d
Compare
|
I need to fix the periodic e2e failures introduced by this change. |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
marun
force-pushed
the
e2e-simplify-key-usage
branch
3 times, most recently
from
2474cf6
to
c8d8497
Compare
marun
force-pushed
the
e2e-simplify-key-usage
branch
9 times, most recently
from
f74a6af
to
4662df7
Compare
|
Rebased and updated to use explicit change owners for wallets with multiple keys. |
marun
force-pushed
the
e2e-simplify-key-usage
branch
from
cbbbbb1
to
926742b
Compare
As part of refactoring the e2e tests for reuse in antithesis and load testing, this change simplifies key usage so that tests can be supplied a specific pre-funded key rather than retrieving their own key at runtime. Fund usage is also minimized. It should be possible to run most tests repeatedly for extended periods of time without running out of keys or funds. Previously, pre-funded keys were distributed via an http server to ensure a given key was used by at most a single test. This was intended to ensure compatibility with parallel test execution by guaranteeing that no pre-funded key would ever be used concurrently. Since ginkgo uses process-based parallization, it's sufficient to ensure that each process is allocated a single unique key. The tests assigned to run in a given test process are executed sequentially so a key won't be in danger of concurrent usage. As part of this change, the virtuous test was updated to use one pre-funded key to fund a new set of keys. Previously 10 pre-funded keys were required.
This avoids having a large balance on one key being transfered to a different key by the wallet randomly selecting a key for change output.
marun
force-pushed
the
e2e-simplify-key-usage
branch
from
926742b
to
6a8f855
Compare
| tc.WithDefaultContext(), | ||
| ) | ||
| require.NoError(err) | ||
| } | ||
|
|
||
| runFunc := func(round int) { |
There was a problem hiding this comment.
Note to myself: This test looks... Interesting... Should look to see what the use actually is.
StephenButtolph
approved these changes
Aug 21, 2024
dhrubabasu
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As part of refactoring the e2e tests for reuse in antithesis and load testing, this change simplifies key usage so that tests can be supplied a specific pre-funded key rather than retrieving their own key at runtime. Fund usage is also minimized . It should be possible to run most tests repeatedly for extended periods of time without running out of keys or funds.
How this works
Previously, pre-funded keys were distributed via an http server to ensure a given key was used by at most a single test. This was intended to ensure compatibility with parallel test execution by guaranteeing that no pre-funded key would ever be used concurrently.
Since ginkgo uses process-based parallization, it's sufficient to ensure that each process is allocated a unique key. The tests assigned to run in a given test process are executed sequentially so a key won't be in danger of concurrent usage.
As part of this change, the virtuous test was updated to use the one funded key to fund a new set of keys. Previously 10 pre-funded keys were required.
How this was tested
CI, local parallel execution