Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests related to jti and jwtid #544

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

MitMaro
Copy link
Contributor

@MitMaro MitMaro commented Oct 24, 2018

Next PR for #492

This change extracts all tests in the existing test files related to jwtid and jti into a single test file. Several other tests are also added that were missing from the existing files.

All references to jwtid and jti have been removed from the existing test files.

As always, suggestions or missing tests are more than welcome!

Coverage Master

=============================== Coverage summary ===============================
Statements   : 97.07% ( 232/239 )
Branches     : 97.57% ( 201/206 )
Functions    : 100% ( 23/23 )
Lines        : 97.46% ( 230/236 )
================================================================================

Coverage Branch

=============================== Coverage summary ===============================
Statements   : 97.07% ( 232/239 )
Branches     : 97.57% ( 201/206 )
Functions    : 100% ( 23/23 )
Lines        : 97.46% ( 230/236 )
================================================================================

@MitMaro
Copy link
Contributor Author

MitMaro commented Oct 25, 2018

@ziluvatar Looks like the build needs to be restarted, when you get a moment. The Node 7 build seems to have stalled.

Copy link
Contributor

@ziluvatar ziluvatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitMaro there are some conflicts created after merging your other PRs.

@MitMaro
Copy link
Contributor Author

MitMaro commented Nov 2, 2018

I figured that could happen with these PRs. I will rebase against the latest changes when I get a chance.

This change extracts all tests related to the jti claim and the jwtid
option into a single test file. Additional tests were added that were
missing.
@MitMaro
Copy link
Contributor Author

MitMaro commented Nov 21, 2018

@ziluvatar I forgot to ping you when I did the rebase a few weeks ago. I've rebase again against the latest from master.

@ziluvatar ziluvatar merged commit 7eebbc7 into auth0:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants