Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for config current #193

Merged
merged 5 commits into from
Jan 25, 2022
Merged

test: add test for config current #193

merged 5 commits into from
Jan 25, 2022

Conversation

imabp
Copy link
Member

@imabp imabp commented Jan 23, 2022

Description

  • Added a test specification for asyncapi config context current
    image

Related issue(s)

github-actions[bot]
github-actions bot reviewed Jan 23, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@imabp imabp changed the title Add Test for config current test: add test for config current Jan 23, 2022
@imabp
Copy link
Member Author

imabp commented Jan 24, 2022

👋 Hey @fmvilas @derberg.
please review the code and run the workflow as it requires maintainer level access.
😁

@derberg
Copy link
Member

derberg commented Jan 24, 2022

@imabp there are some linting issues that you need to look into.

@imabp
Copy link
Member Author

imabp commented Jan 24, 2022

Hey, @derberg I have fixed the lint :)
Please feel free to re-run the workflows 😊

derberg
derberg previously approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Souvikns anything from your side?

Souvikns
Souvikns requested changes Jan 24, 2022
View reviewed changes
test/commands/context.test.ts Outdated Show resolved Hide resolved
@imabp
Copy link
Member Author

imabp commented Jan 24, 2022

@Souvikns fixed the required changes.
Please feel free to review and merge 😄

Souvikns
Souvikns approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍🏻. Just update the branch accordingly

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imabp
Copy link
Member Author

imabp commented Jan 24, 2022

@Souvikns I have updated the branch, please merge.

@Souvikns Souvikns merged commit 6ade22d into asyncapi:master Jan 25, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.12.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@Souvikns Souvikns Souvikns approved these changes

@derberg derberg Awaiting requested review from derberg

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imabp @derberg @asyncapi-bot @Souvikns