Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Pin tool and package versions to make builds more repeatable #7013

Merged
merged 2 commits into from
Nov 1, 2017

Conversation

natemcmaster
Copy link
Contributor

Part of aspnet/Universe#575 and aspnet/KoreBuild#239

This removes floating versions of dependencies. This includes the korebuild version and versions used by PackageReference's.

Changes:

  • build.cmd /t:Pin is no longer required to use Mvc.sln
  • (script generated) replace PackageLineup with MSBuild variables for dependencies versions

@natemcmaster
Copy link
Contributor Author

cc @javiercn - as a part of this change, we're also verifying that packages produced by a repo have consistent versions. I noticed that Microsoft.AspNetCore.Mvc.Testing is 2.1.0-alpha1, but the rest of the repo is 2.1.0-preview1. What was the reason for this change? #6521 I didn't see any discussion or sign-off.

@javiercn
Copy link
Member

@natemcmaster It happened offline. We wanted to have an alpha that people could use with 2.0. It is safe at this point to make it 2.1.0-preview1 like the rest of the packages

@natemcmaster
Copy link
Contributor Author

Ok, thanks for the clarification. I'll update that in this PR too so we don't get build warnings.

@natemcmaster natemcmaster merged commit 2e4bc54 into dev Nov 1, 2017
@natemcmaster natemcmaster deleted the namc/reproducible-builds branch November 1, 2017 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants