-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reshim
did not rewrite executable path
#1311
Merged
jthegedus
merged 13 commits into
asdf-vm:master
from
dylan-chong:fix-reshim-does-not-rewrite-file
Dec 20, 2022
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
01b4bda
fix: reshim does not rewrite file
dylan-chong ec53493
Fix multiple shim versions, but still generate new shim file
dylan-chong ca82d92
Remove debugging code, simplify
dylan-chong 38fe5e3
Don't use banned command
dylan-chong f5b293a
Even less code
dylan-chong dccaa32
Even simpler
dylan-chong 3ce43fd
Add test
dylan-chong 91ab906
Merge branch 'master' into fix-reshim-does-not-rewrite-file
jthegedus 80bcc40
chore: fix SC2006
jthegedus c904b07
fix: add tmp_path
jthegedus 61226ae
chore: format code as per shfmt
jthegedus 96f4722
chore: format as per sfmt
jthegedus ea11400
Delete unused
dylan-chong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure line 91-92 are necessary as
mktemp
should fallback toTMPDIR
and/tmp
automatically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jthegedus, do you have any thoughts since you added this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed fine to me, but after looking at existing use of
mktemp
this was the outlier, so I changed it to align with the other usages. We can back this out later once we clean up and decide to put this behind a function or something.