Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid connect options, when using browserURL #212

Merged
merged 3 commits into from
Mar 13, 2019
Merged

fix invalid connect options, when using browserURL #212

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1296edd
fix invalid connect options, when using browserURL
backbone87 Mar 12, 2019
56bc9a8
harden teardown
backbone87 Mar 12, 2019
8bf3cb2
fix linting
backbone87 Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix linting
  • Loading branch information
@backbone87
backbone87 committed Mar 13, 2019
commit 8bf3cb26734e37a2d4394605bb56f5d79d441da0
6 changes: 2 additions & 4 deletions packages/jest-environment-puppeteer/src/PuppeteerEnvironment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,8 @@ class PuppeteerEnvironment extends NodeEnvironment {
if (context) {
await context.close()
}
} else {
if (page) {
await page.close()
}
} else if (page) {
await page.close()
}

if (browser) {
Expand Down