Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude argocd-server rbac for core-install #8234

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

chetan-rns
Copy link
Member

Signed-off-by: Chetan Banavikalmutt chetanrns1997@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Core installation doesn't rely on argocd-server. This PR removes the unused argocd-server RBAC from the core install manifest

Closes: #7760

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #8234 (d2638d4) into master (6962fc2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8234   +/-   ##
=======================================
  Coverage   41.63%   41.63%           
=======================================
  Files         174      174           
  Lines       22731    22731           
=======================================
  Hits         9464     9464           
  Misses      11910    11910           
  Partials     1357     1357           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6962fc2...d2638d4. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chetan-rns ! LGTM

@alexmt alexmt merged commit ae71475 into argoproj:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core-install manifest references undefined argocd-server ServiceAccount
2 participants