Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify expected ARGOCD_EXEC_TIMEOUT value format #8029

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

vavdoshka
Copy link
Contributor

Specifying the value format to avoid ambiguity due to mentioned default "90 seconds timeout"

@vavdoshka vavdoshka changed the title DOC: Clarify expected ARGOCD_EXEC_TIMEOUT value format docs: Clarify expected ARGOCD_EXEC_TIMEOUT value format Dec 23, 2021
… default "90 seconds timeout"

Signed-off-by: Vladimir Avdoshka <vova.avdoshka@gmail.com>
Signed-off-by: Vladimir Avdoshka <vavdoshka@kyriba.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving docs!

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #8029 (3b3f01a) into master (000f951) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8029   +/-   ##
=======================================
  Coverage   41.54%   41.54%           
=======================================
  Files         174      174           
  Lines       22681    22681           
=======================================
  Hits         9422     9422           
  Misses      11918    11918           
  Partials     1341     1341           
Impacted Files Coverage Δ
util/settings/settings.go 46.85% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000f951...3b3f01a. Read the comment docs.

@alexmt alexmt merged commit 113b3da into argoproj:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants