chore: Run dex reverse proxy only when dex is configured #7999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #7999 +/- ##
=======================================
Coverage 41.47% 41.47%
=======================================
Files 173 173
Lines 22587 22587
=======================================
Hits 9369 9369
Misses 11886 11886
Partials 1332 1332
Continue to review full report at Codecov.
|
jannfis
approved these changes
Jan 15, 2022
There was a problem hiding this comment.
LGTM! This changes actually makes sense, thanks @mkilchhofer !
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Jan 27, 2022
…oproj#7999)" This reverts commit 303cc46. Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
jannfis
pushed a commit
that referenced
this pull request
Jan 27, 2022
pasha-codefresh
pushed a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Feb 2, 2022
…oproj#7999)" (argoproj#8291) This reverts commit 303cc46. Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While analysing this issue here (argoproj/argo-helm#615 (comment)) from the community repo, it seems that the reverse proxy for Dex can be optimised.
When using external SSO only, the reverse proxy for
/api/dexseems unneeded.Feel free to decline this small improvement or request additional info. 😉
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: