Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add gitattributes #392

Merged
merged 1 commit into from
May 4, 2020
Merged

Conversation

viezel
Copy link
Contributor

@viezel viezel commented May 4, 2020

Improve the distribution size of this package, as there is no reason to ship tests, github workflow and various test files with composer.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #392 into master will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
- Coverage     88.94%   88.64%   -0.31%     
  Complexity      469      469              
============================================
  Files            65       65              
  Lines          1303     1303              
============================================
- Hits           1159     1155       -4     
- Misses          144      148       +4     
Impacted Files Coverage Δ Complexity Δ
src/Commands/Install.php 88.23% <0.00%> (-11.77%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c90ff...112bb10. Read the comment docs.

@viezel
Copy link
Contributor Author

viezel commented May 4, 2020

@stancl no idea why it thinks code coverage went down, as I did not add any executable code in this PR. 🤷🏻‍♂️

@stancl
Copy link
Member

stancl commented May 4, 2020

Makes sense, good idea!

@stancl stancl merged commit 726a046 into archtechx:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants