Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(java): stop supporting of test scope for pom.xml files #7488

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

We discovered a few problems with #7414:

  1. Child dependencies of test dependency are not marked as Dev (see feat(java): add support of test scope for pom.xml files #7486).
  2. Trivy scans test dependencies even if --include-dev-deps flag doesn't present (this is due to our logic for excluding dev dependencies). Not being able to disable test dependency scanning slows down Trivy significantly. More details in enhancement(report): include/exclude dev deps in analyzers #7476.

Fixing these issues will take some time to be considered.
To avoid further issues with fast merging, we have decided to revert #7414.
The functionality of #7414 will be added in other PRs.

Related issues

Related PRs

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into aquasecurity:main with commit b0222fe Sep 12, 2024
17 checks passed
@DmitriyLewen DmitriyLewen deleted the revert/pom-test-scope branch September 12, 2024 05:43
@DmitriyLewen
Copy link
Contributor Author

@aqua-bot backport release/v0.55

@aqua-bot
Copy link
Contributor

Backport PR created: #7489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants