Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(java): add support of test scope for pom.xml files #7486

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat(java): add support of test scope for pom.xml files #7486

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eaf6b88
fix: mark child deps of test dependency as Dev
DmitriyLewen Sep 11, 2024
09fd4b4
test: add unit test
DmitriyLewen Sep 11, 2024
51c9d37
fix: compare `test scope` for same artifacts
DmitriyLewen Sep 11, 2024
6deda97
test: update test for `test` scope
DmitriyLewen Sep 11, 2024
11cdd3e
refactor: disable `gocyclo` for `parseRoot`
DmitriyLewen Sep 11, 2024
76f4342
Merge branch 'main' into 'fix-pom/child-test-deps'
DmitriyLewen Sep 12, 2024
d1abac5
docs: add info about scopes
DmitriyLewen Sep 13, 2024
4b29756
fix: add missing changes after merging main branch
DmitriyLewen Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: disable gocyclo for parseRoot
  • Loading branch information
@DmitriyLewen
DmitriyLewen committed Sep 11, 2024
commit 11cdd3e4724e2664561d1de9098287a52ed59acf
1 change: 1 addition & 0 deletions pkg/dependency/parser/java/pom/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ func (p *Parser) Parse(r xio.ReadSeekerAt) ([]ftypes.Package, []ftypes.Dependenc
return p.parseRoot(root.artifact(), make(map[string]struct{}))
}

// nolint: gocyclo
func (p *Parser) parseRoot(root artifact, uniqModules map[string]struct{}) ([]ftypes.Package, []ftypes.Dependency, error) {
// Prepare a queue for dependencies
queue := newArtifactQueue()
Expand Down