Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort ClusterRole rules by apiGroups, resources #321

Merged

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jul 13, 2022

Description

This is the next in line towards resolving #204. Since controller-gen is sorting the RBAC rules by apiGroups, then resources, I think it is safest if we do the sorting as a pre-PR before migrating to generating the clusterrole. Please let me know if you can think of a more review-friendly approach...

Next PR before migrating to generating will be yaml lists formatting.

Related issues

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the refactor/sort-cluster-role-rules branch from 278c3bf to 7b4d0d4 Compare July 13, 2022 21:59
@josedonizetti josedonizetti merged commit 98675ff into aquasecurity:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants