Add VAR_DEPENDS feature to auto options
#11729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the variables listed in `VAR_DEPENDS` need to be truthy for the feature to be enabled. This will be used for ja4_fingerprint to require vanilla OpenSSL.
Merged
|
The AuTest remap_acl failed. |
cmcfarlen
previously approved these changes
Aug 21, 2024
* Hint that the issue can be resolved by enabling the variable. The message is intentionally vague, because unfortunately, it may be an internal variable that should not/cannot be directly enabled.
cmcfarlen
approved these changes
Aug 21, 2024
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Aug 22, 2024
* Add `VAR_DEPENDS` feature to auto options All the variables listed in `VAR_DEPENDS` need to be truthy for the feature to be enabled. This will be used for ja4_fingerprint to require vanilla OpenSSL. * Implement changes suggested by Chris McFarlen * Hint that the issue can be resolved by enabling the variable. The message is intentionally vague, because unfortunately, it may be an internal variable that should not/cannot be directly enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the variables listed in
VAR_DEPENDSneed to be truthy for the feature to be enabled. This will be used for ja4_fingerprint to require vanilla OpenSSL.