Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC: Fix a bug that ssl_multicert.config is not reloaded for QUIC #11723

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

maskit
Copy link
Member

@maskit maskit commented Aug 20, 2024

The fix is in SSLClientCoordinator. It's simply lacks the line for QUIC.

The log output format is slightly changed because it'd look like same config file is reloaded twice if it doesn't have a tag name (The file is loaded twice for two contexts, Regular TLS (on TCP) and QUIC).

@maskit maskit added the QUIC label Aug 20, 2024
@maskit maskit added this to the 10.1.0 milestone Aug 20, 2024
@maskit maskit self-assigned this Aug 20, 2024
JosiahWI
JosiahWI previously approved these changes Aug 20, 2024
Copy link
Contributor

@JosiahWI JosiahWI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@maskit Looks like the new line needs to be conditionally compiled based on whether QUIC is being built.

@maskit maskit merged commit 8e03d9e into apache:master Aug 21, 2024
15 checks passed
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Aug 22, 2024
…pache#11723)

* QUIC: Fix a bug that ssl_multicert.config is not reloaded for QUIC

* Add ifdef
@cmcfarlen
Copy link
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request Aug 30, 2024
…11723)

* QUIC: Fix a bug that ssl_multicert.config is not reloaded for QUIC

* Add ifdef

(cherry picked from commit 8e03d9e)
@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.0.1 Sep 10, 2024
@maskit maskit deleted the quic_config_reload branch September 18, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Picked-10.0.1
Development

Successfully merging this pull request may close these issues.

3 participants