Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify num-nulls handling in Statistics and ColumnIndex #449

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Clarify num-nulls handling in Statistics and ColumnIndex #449

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dbfe60f
Clarify num-nulls handling
mapleFU Aug 16, 2024
0ebe97f
Update src/main/thrift/parquet.thrift
mapleFU Aug 19, 2024
d3f210f
Add readers behavior
mapleFU Aug 21, 2024
2e0df3a
Apply suggestions from code review
mapleFU Aug 21, 2024
fe815ea
Reader: change SHOULD to MUST
mapleFU Aug 21, 2024
1508aa2
Add for ColumnIndex
mapleFU Aug 21, 2024
0bf50c5
Apply suggestions from code review
mapleFU Aug 21, 2024
4dc4502
Update src/main/thrift/parquet.thrift
mapleFU Aug 21, 2024
aee6e1e
Update src/main/thrift/parquet.thrift
mapleFU Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/main/thrift/parquet.thrift 
Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com>
  • Loading branch information
@mapleFU @etseidl
mapleFU and etseidl committed Aug 21, 2024
commit aee6e1e6a129be3514fbdc009ec14e0e61af28be
4 changes: 2 additions & 2 deletions src/main/thrift/parquet.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,8 +1094,8 @@ struct ColumnIndex {
/**
* A list containing the number of null values for each page
*
* Writers SHOULD always write this field even if no null value
* or the column is not nullable.
* Writers SHOULD always write this field even if no null values
* are present or the column is not nullable.
* Readers MUST distinguish between null_counts not being present
* and null_count being 0.
* If null_counts are not present, readers MUST NOT assume all
Expand Down