Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4338. Fix the issue that SCM web UI banner shows "HDFS SCM". #1583

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

yuyang733
Copy link
Contributor

What changes were proposed in this pull request?

Fix the issue that the SCM web UI banner shows "HDFS SCM". Change the "HDFS SCM" to the "Ozone SCM".

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4338

How was this patch tested?

Passed all default unit tests and checked it after the actual startup.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuyang733 for the patch. It LGTM. A few other places that should be fixed.

hddsDatanode/index.html
Line25: HDFS=>HDDS

scm/index.html, in addition to the fix included in the patch at line 49, two other places need to be fixed.
Line 25/27 HDFS->HDDS

@yuyang733
Copy link
Contributor Author

Thanks @yuyang733 for the patch. It LGTM. A few other places that should be fixed.

hddsDatanode/index.html
Line25: HDFS=>HDDS

scm/index.html, in addition to the fix included in the patch at line 49, two other places need to be fixed.
Line 25/27 HDFS->HDDS

Thanks for your comments. I have fixed it.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@xiaoyuyao xiaoyuyao merged commit 0e35176 into apache:master Nov 13, 2020
@xiaoyuyao
Copy link
Contributor

Thanks @yuyang733 for the contribution. PR has been merged.

@yuyang733 yuyang733 deleted the HDDS-4338 branch November 13, 2020 17:24
errose28 added a commit to errose28/ozone that referenced this pull request Nov 18, 2020
* master: (53 commits)
  HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585)
  HDDS-4442. Disable the location information of audit logger to reduce overhead (apache#1567)
  HDDS-4441. Add metrics for ACL related operations.(Addendum for HA). (apache#1584)
  HDDS-4081. Create ZH translation of StorageContainerManager.md in doc. (apache#1558)
  HDDS-4080. Create ZH translation of OzoneManager.md in doc. (apache#1541)
  HDDS-4079. Create ZH translation of Containers.md in doc. (apache#1539)
  HDDS-4184. Add Features menu for Chinese document. (apache#1547)
  HDDS-4235. Ozone client FS path validation is not present in OFS. (apache#1582)
  HDDS-4338. Fix the issue that SCM web UI banner shows "HDFS SCM". (apache#1583)
  HDDS-4337. Implement RocksDB options cache for new datanode DB utilities. (apache#1544)
  HDDS-4083. Create ZH translation of Recon.md in doc (apache#1575)
  HDDS-4453. Replicate closed container for random selected datanodes. (apache#1574)
  HDDS-4408: terminate Datanode when Datanode State Machine Thread got uncaught exception. (apache#1533)
  HDDS-4443. Recon: Using Mysql database throws exception and fails startup (apache#1570)
  HDDS-4315. Use Epoch to generate unique ObjectIDs (apache#1480)
  HDDS-4455. Fix typo in README.md doc (apache#1578)
  HDDS-4441. Add metrics for ACL related operations. (apache#1571)
  HDDS-4437. Avoid unnecessary builder conversion in setting volume Quota/Owner request (apache#1564)
  HDDS-4417. Simplify Ozone client code with configuration object (apache#1542)
  HDDS-4363. Add metric to track the number of RocksDB open/close operations. (apache#1530)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants