HDDS-4327. Potential resource leakage using BatchOperation. #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @bharatviswa504 for fixing this.
Have one question (posted inline). LGTM otherwise.
| for (Map.Entry<Long, Long> entry : deleteTransactionMap.entrySet()) { | ||
| try(org.apache.hadoop.hdds.utils.db.BatchOperation batchOperation = | ||
| batchHandler.initBatchOperation()) { | ||
| lock.lock(); |
There was a problem hiding this comment.
Shouldn't lock() be called outside the try block? If there is a chance that the initBatchOperation() can fail, then lock.unlock() would throw IllegalMonitorStateException as the lock is not held by it.
There was a problem hiding this comment.
Good catch. Fixed in the latest commit.
|
Thanks @bharatviswa504. +1 for merge. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Oct 19, 2020
* master: HDDS-4301. SCM CA certificate does not encode KeyUsage extension properly (apache#1468) HDDS-4158. Provide a class type for Java based configuration (apache#1407) HDDS-4297. Allow multiple transactions per container to be sent for deletion by SCM. HDDS-2922. Balance ratis leader distribution in datanodes (apache#1371) HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory. (apache#1490) HDDS-4327. Potential resource leakage using BatchOperation. (apache#1493) HDDS-3995. Fix s3g met NPE exception while write file by multiPartUpload (apache#1499) HDDS-4343. ReplicationManager.handleOverReplicatedContainer() does not handle unhealthyReplicas properly. (apache#1495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Potential resource leakage using BatchOperation.
Use try enclosed resource/close the batch once after it usage is completed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4327
How was this patch tested?
Existing tests.