HDDS-3685. Remove replay logic from actual request logic. #1082
Conversation
bharatviswa504
force-pushed
the
HDDS-3685
branch
from
e24ad28
to
b9e88ca
Compare
bharatviswa504
force-pushed
the
HDDS-3685
branch
from
6997361
to
79ed27b
Compare
|
Rebased patch with the latest master. |
There was a problem hiding this comment.
Thanks @bharat for working on this. Looks good overall.
I have very minor questions/ comments.
OMKeysDeleteResponse seems to have been missed in the cleanup.
| openPartKeyInfoToBeDeleted, repeatedOmKeyInfo, | ||
| openPartKeyInfoToBeDeleted.getUpdateID(), isRatisEnabled); | ||
| OmUtils.prepareKeyForDelete(openPartKeyInfoToBeDeleted, | ||
| repeatedOmKeyInfo, omMultipartKeyInfo.getUpdateID(), isRatisEnabled); |
There was a problem hiding this comment.
Should this return value be set to repeatedOmKeyInfo?
| @@ -223,6 +223,6 @@ public String toString() { | |||
|
|
|||
| INVALID_VOLUME_NAME, | |||
|
|
|||
| REPLAY // When ratis logs are replayed. | |||
| REPLAY | |||
There was a problem hiding this comment.
Any reason for keeping this around?
There was a problem hiding this comment.
Initially, the reason was because proto.lock file, if any breaking changes, it will fail to compile. I have removed this, as anyway HA is part of this release, and we can remove this field.
cc @avijayanhwx
There was a problem hiding this comment.
The general guideline is breaking API changes are allowed pre-GA, but not after that.
…to, as now it is locked, compilation fails
bharatviswa504
force-pushed
the
HDDS-3685
branch
from
e28fd63
to
82eb62e
Compare
|
Thank You @hanishakoneru for the review. |
|
Thanks @bharatviswa504 for working on this. |
|
Thank You @hanishakoneru for the review and @avijayanhwx for the confirmation on proto changes. |
What changes were proposed in this pull request?
Remove the replay logic from actual requests.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3685
How was this patch tested?
Existing tests, will add a few more tests to cover this scenario.