Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix the installation doc for MKL-DNN backend #12534

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Sep 12, 2018

Description

This is a follow-up for #12509
@lupesko @aaronmarkham @pengzhao-intel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv requested a review from szha as a code owner September 12, 2018 16:30
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronmarkham
Copy link
Contributor

How do you install MKL-DNN with pip?
Do you get it with pip install mxnet-mkl? Or must you build from source?

@TaoLv
Copy link
Member Author

TaoLv commented Sep 12, 2018

Yes, we can get MKL-DNN with pip install mxnet-mkl. But I think this package is built with USE_BLAS=openblas and USE_MKLDNN=1.

@TaoLv
Copy link
Member Author

TaoLv commented Sep 14, 2018

Since #12509 is already merged, do you think this PR is good to go? @aaronmarkham @lupesko @szha

@kalyc
Copy link
Contributor

kalyc commented Sep 14, 2018

Thanks for your contribution @TaoLv
@mxnet-label-bot[pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Sep 14, 2018
@marcoabreu marcoabreu merged commit ff10e1a into apache:master Sep 17, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* fix build from souce doc for mkldnn backend

* fix doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants