-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7547] Simpler G level metadata generation #806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
commented
Sep 23, 2022
cstamas
commented
Sep 23, 2022
cstamas
commented
Sep 23, 2022
...er-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadataGenerator.java
Outdated
Show resolved
Hide resolved
cstamas
commented
Sep 23, 2022
...er-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadataGenerator.java
Outdated
Show resolved
Hide resolved
cstamas
changed the title
Simpler G level metadata generation
[MNG-7547] Simpler G level metadata generation
Sep 24, 2022
gnodet
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big +1 for that one
cstamas
force-pushed
the
plugin-metadata
branch
from
September 30, 2022 19:02
dd9a602
to
9a5d783
Compare
The branch http://github.com/gnodet/maven/tree/plugin-metadata fixes the conflict and also remove the metadata from the v4 api. |
michael-o
requested changes
Oct 4, 2022
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadata.java
Show resolved
Hide resolved
...er-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadataGenerator.java
Show resolved
Hide resolved
...er-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadataGenerator.java
Show resolved
Hide resolved
@cstamas Can you please rebase? I want to test this as well. |
cstamas
force-pushed
the
plugin-metadata
branch
from
October 8, 2022 09:36
a73a41a
to
79e0279
Compare
@michael-o rebased |
Going through... |
michael-o
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just inspect deployed artifacts, try to find a plugin among them and reuse PluginDescriptor embedded in it.
https://issues.apache.org/jira/browse/MNG-7547