Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature:update-checkstyle] Limit the java file header #1799

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

YxYL6125
Copy link
Contributor

What's changed?

refer to: #1781

add module to checkstyle.xml

<module name="RegexpSinglelineJava">
    <property name="format" 
              value="^.*(@author|@date).*" />
    <property name="message" 
              value="Java file header cannot contain @author or @date" />
</module>

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 20, 2024
@tomsun28 tomsun28 merged commit 38fb151 into apache:master Apr 20, 2024
2 checks passed
@YxYL6125 YxYL6125 deleted the feature-update-checkstyle branch April 21, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants