HBASE-18901 [C++] Provide CMAKE infrastructure #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phrocker
force-pushed
the
HBASE-14850-mparisi
branch
2 times, most recently
from
636524e
to
1cb9ef5
Compare
|
Note that some of the cmake modules are derivative of previous work that I've done, which was likely derivative work of someone else's work years past. How would you like me to handle this? Even if I didn't immediately reference or copy their cmake module I'd be happy to document somewhere that something may be a derivative work as a result of someone else's efforts that I've propagated via memory. |
phrocker
force-pushed
the
HBASE-14850-mparisi
branch
4 times, most recently
from
c5a15c5
to
b36e896
Compare
* Provided cmake files for packages in which a default module did not exist. * Moved tests to a location where we could automatically build the test suite. * Resolved minor issues with tests * Tested across OSX, RHEL7, and Ubuntu16 HBASE-18901 [C++] Cleanup CMAKE JJELSER: A hack to get the protobuf-gen headers installed too. Admittedly, not sure if there is a better way to do it. HBASE-18901 [C++] Fix PROTOBUF_LIBRARY by removing static override in FindZookeeper HBASE-18901 [C++] Remove white space lines and clean up CMAKE
phrocker
force-pushed
the
HBASE-14850-mparisi
branch
from
b36e896
to
5ed5927
Compare
|
This PR is slated to be closed as a part of HBASE-20391 because the referenced JIRA has since closed. If this is incorrect and you are still interested in working on the issue please comment there and/or reopen the PR. |
This was referenced Aug 25, 2019
Merged
Closed
This was referenced Jan 24, 2022
Merged
Merged
Closed
Merged
This was referenced Jan 31, 2022
Merged
This was referenced Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did not exist.
the test suite.
HBASE-18901 [C++] Cleanup CMAKE