-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23645][Table SQL / Client] Fix SqlClient doesn't response correctly to Signal.INT #16743
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f83e553 (Fri Aug 06 11:06:33 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
hi @wuchong , do you have time review this pr ? |
cc @fsk119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great work. I left some comments.
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Fix SqlClient doesn't response correctly to Signal.INT
Brief change log
Sqlclient would interupt the Executor when receive Signal.INT before ResultView opening
Verifying this change
Added test case in org.apache.flink.table.client.cli.CliClientTest.testCancelExecutionInteractiveMode
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation