[FLINK-19649][sql-parser] Fix unparse method of sql create table. Kee…

…p syntax the same for tables without columns
apache · Oct 15, 2020 · eb69ec2 · eb69ec2
1 parent d5e34a5
commit eb69ec2
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/...-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java b/...-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
@@ -265,24 +265,26 @@ public void unparse(
 			writer.keyword("IF NOT EXISTS");
 		}
 		tableName.unparse(writer, leftPrec, rightPrec);
-		SqlWriter.Frame frame = writer.startList(SqlWriter.FrameTypeEnum.create("sds"), "(", ")");
-		for (SqlNode column : columnList) {
-			printIndent(writer);
-			column.unparse(writer, leftPrec, rightPrec);
-		}
-		if (tableConstraints.size() > 0) {
-			for (SqlTableConstraint constraint : tableConstraints) {
+		if (columnList.size() > 0) {
+			SqlWriter.Frame frame = writer.startList(SqlWriter.FrameTypeEnum.create("sds"), "(", ")");
+			for (SqlNode column : columnList) {
 				printIndent(writer);
-				constraint.unparse(writer, leftPrec, rightPrec);
+				column.unparse(writer, leftPrec, rightPrec);
+			}
+			if (tableConstraints.size() > 0) {
+				for (SqlTableConstraint constraint : tableConstraints) {
+					printIndent(writer);
+					constraint.unparse(writer, leftPrec, rightPrec);
+				}
+			}
+			if (watermark != null) {
+				printIndent(writer);
+				watermark.unparse(writer, leftPrec, rightPrec);
 			}
-		}
-		if (watermark != null) {
-			printIndent(writer);
-			watermark.unparse(writer, leftPrec, rightPrec);
-		}
 
-		writer.newlineAndIndent();
-		writer.endList(frame);
+			writer.newlineAndIndent();
+			writer.endList(frame);
+		}
 
 		if (comment != null) {
 			writer.newlineAndIndent();