-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-3218] Added Quota checks for PubsubMessage in PubsubBoundedWriter #4275
Conversation
0c75646
to
8926feb
Compare
347706c
to
383e7a7
Compare
Sorry about the delay. Reuven, could you review or pass to someone whose familiar with PubSubIO ? |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
Bump, will address feedback here |
We have turned on autoformatting of the codebase, which causes small conflicts across the board. You can probably safely rebase and just keep your changes. Like this:
Please ping me if you run into any difficulty. |
074dd55
to
f706541
Compare
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue.mvn clean verify
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.BEAM-3218
This PR adds a check in the PubsubBoundedWriter to ensure the size of a publish request is within the allowed quota. There's an additional change in the PR which also adds quota checks on PubsubMessage object creation, specifically ensuring a message does not:
based on the quotas here.